Skip to content

failCommentCondition isnt checked for "success" step #1025

@rhys-childs

Description

@rhys-childs
Contributor

failComment is marked as deprecated, but failCommentCondition isn't actually checked in the success step like failComment was.

failCommentCondition was added to the config here

The deprecation warning was added to the fail step for failComment here

But the same check is not performed here

The result is that you have to use the deprecated failComment config value to disable issue checking on the success step.

Activity

rhys-childs

rhys-childs commented on Apr 14, 2025

@rhys-childs
ContributorAuthor

Ive opened a PR to resolve it

github-actions

github-actions commented on Aug 10, 2025

@github-actions

🎉 This issue has been resolved in version 11.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @rhys-childs

      Issue actions

        failCommentCondition isnt checked for "success" step · Issue #1025 · semantic-release/github