-
Notifications
You must be signed in to change notification settings - Fork 140
feat: deprecate github search api consumption #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@babblebey since this will be a breaking change, i retargeted this PR at the what do you consider to be the current state of this change? do you have much more to do for this to be ready to merge? |
in this context, i just meant the beta of the npm plugin to get us to the latest major version. part of the motivation for that is for the upcoming oidc support for semantic-release/npm#958, but that is only just getting started. assuming it goes smoothly, i would like that support to be included in the upcoming major, but no guarantees yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. thanks for getting this taken care of!
🎉 This PR is included in version 12.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR completely removes the consumption of the github search API from the plugin; following its relegation in #907 and the deprecation notice of the endpoint itself from github.
BREAKING CHANGE
@semantic-release/github
no longer consumes the GitHub Search API in the pluginRelated Issue
Fixes #1022