Skip to content

Fix options with isTag field #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zoey1988
Copy link

options with isTag

If for any reason, options given as prop includes records with isTag property (in our project, we used isTag property for another purpose), but taggable prop was not provided or set to false, those records are considered as tag which we don't want that.

It's better that before checking if an option has isTag field, we check if taggable prop is true.

@Zoey1988 Zoey1988 changed the title fix options with isTag field Fix options with isTag field Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant