Change Start Position of Dropdown #951
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shentao - any feedback on this? |
shentao
requested changes
Apr 27, 2019
| @@ -33,6 +42,20 @@ export default { | |||
| this.pointerAdjust() | |||
| }, | |||
| isOpen () { | |||
| if (!this.hideSelected && this.scrollToSelected && this.value) { | |||
| let value = JSON.parse(JSON.stringify(this.value)) | |||
There was a problem hiding this comment.
Let’s try to avoid removing the reference from the value. Would be best to approach this problem without having to mutate anything. Also, doing parse/stringify will throw errors with recursive objects that might sometimes be a case.
There was a problem hiding this comment.
A multiselect array will scroll to the first item in the values array. If this is inadequate, do you have any suggestions?
Do you have a suggestion for the isOpen block other than not using parse/stringify?
|
Is this making it into the next release? I could use this on multiple projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to scroll the dropdown content to the selected item when opened using the prop
scrollToSelected743