Skip to content

windows: Use a default stack size of 8MB #8711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Conversation

tronical
Copy link
Member

This matches Linux and avoids annoying stack overflows, especially when running our own demos (see printerdemo).

This is now also documented for our users.

Fixes #4586

This matches Linux and avoids annoying stack overflows, especially when running our own demos (see printerdemo).

This is now also documented for our users.

Fixes #4586
@tronical tronical requested a review from ogoffart June 16, 2025 12:59
@tronical tronical changed the title windows: Use a default stack size of 10MB windows: Use a default stack size of 8MB Jun 16, 2025

[target.x86_64-pc-windows-msvc]
# Increase default stack size to avoid running out of stack
# space in debug builds. The size matches Linux's default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux default would be 8388608 but i guess that's close enough.

@tronical tronical merged commit 2ea583d into master Jun 16, 2025
38 checks passed
@tronical tronical deleted the simon/windows-stack-size branch June 16, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document what do do when getting STATUS_STACK_OVERFLOW on windows
2 participants