style(clang-tidy): fix modernize-use-ranges checks

[bavulapati]

No description provided.

[jviotti]

Looks good, but can send a draft PR upgrading Core to this PR commit in https://github.com/sourcemeta/jsonschema and see what CI says? If I recall correctly, I think the JSON Schema CLI build will fail as ranges support is not very widespread yet, but maybe I'm wrong. If the CLI works, we can merge :)

[bavulapati]

@jviotti Which standard do we use on jsonschema CLI? Core uses C++20.
And ranges are introduced in C++ 20.

[jviotti]

Yes, it's C++20. The problem is that not all compilers support all C++20 features. Some support only a subset. Last time I tried ranges, it was still not supported on Linux I think, as we build the CLI on Ubuntu 22.04 for higher GLIBC support. If you send a PR to the CLI, we can confirm pretty quickly. You can just update the DEPENDENCIES to point core to the SHA of your PR, run ./vendor/vendorpull/pull core and send a draft PR

[bavulapati]

@jviotti Here we go sourcemeta/jsonschema#391

[jviotti]

Oh wonderful. It worked now. Let's do it!

[jviotti]

@bavulapati Feel free to close the other JSON Schema CLI PR if you want. I'll eventually upgrade Core on it when needed (unless you want to point it to a SHA on main and get it merged)