Skip to content

Display images #309

Open
Open
@eric-burel

Description

@eric-burel
Contributor

Is your feature request related to a problem?

Codemirror editor doesn't seem to support images
image

Describe the solution you'd like.

Display images within the code editor

Describe alternatives you've considered.

This behaviour is implemented in the react package CodeMirrorEditor: "packages/react/src/core/CodeMirrorEditor/BinaryContent.tsx" which is triggered there:
"packages/react/src/core/CodeMirrorEditor/index.tsx"

Additional context

I think this is a good first issue:

  • we can detect images via mime-type
  • and then display them
    Would a PR creating a new "ImageContent" component be accepted? Does display images create any sort of security risk?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @Nemikolh@eric-burel

      Issue actions

        Display images · Issue #309 · stackblitz/tutorialkit