Skip to content

fix: add missing typings for some dimension bindings #16142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

jasonlyu123
Copy link
Member

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Fixes sveltejs/language-tools#2741. The reason it doesn't error with bind:clientWidth={clientWidth} is that language-tools has special handling to generate an assignment in the svelte2tsx virtual code. Alternatively, it could be solved in language tools with a similar handling, but I feel like it's better to keep the types in svelte/elements. Plus, all the other one-way bindings are in svelte/elements. Only these few were missing.

Copy link

changeset-bot bot commented Jun 13, 2025

🦋 Changeset detected

Latest commit: fcac7d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16142

@jasonlyu123 jasonlyu123 changed the title fix: typings for dimension bindings fix: add missing typings for some dimension bindings Jun 13, 2025
@dummdidumm dummdidumm merged commit 6a7df1c into main Jun 13, 2025
14 checks passed
@dummdidumm dummdidumm deleted the dimension-binding-typing branch June 13, 2025 11:59
@github-actions github-actions bot mentioned this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with VSCode Incorrectly Reporting bind:clientWidth as an Error
2 participants