fix: add missing typings for some dimension bindings #16142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint
Fixes sveltejs/language-tools#2741. The reason it doesn't error with
bind:clientWidth={clientWidth}
is that language-tools has special handling to generate an assignment in thesvelte2tsx
virtual code. Alternatively, it could be solved in language tools with a similar handling, but I feel like it's better to keep the types insvelte/elements
. Plus, all the other one-way bindings are insvelte/elements
. Only these few were missing.