Skip to content

The wait_for_publish argument is incorrectly passed as timeout, breaking rate-limiter waiting logic #97

Open
@joshafield

Description

@joshafield

Description

In the send_telemetry and send_attributes methods, the boolean wait_for_publish argument is incorrectly passed to the _publish_data method, where it is mapped to the integer timeout parameter.

This has a side-effect of:

  • If wait_for_publish=True, the timeout is set to 1 second.
  • If wait_for_publish=False, the timeout is set to 0 seconds.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions