Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

this.handleDimensionChange.removeListener is undefined #143

Open
AhsanSheikh02 opened this issue Sep 28, 2023 · 0 comments
Open

this.handleDimensionChange.removeListener is undefined #143

AhsanSheikh02 opened this issue Sep 28, 2023 · 0 comments

Comments

@AhsanSheikh02
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-material-bottom-navigation@1.0.5 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-material-bottom-navigation/lib/BottomNavigation.js b/node_modules/react-native-material-bottom-navigation/lib/BottomNavigation.js
index 08ac9cd..6b29bd1 100644
--- a/node_modules/react-native-material-bottom-navigation/lib/BottomNavigation.js
+++ b/node_modules/react-native-material-bottom-navigation/lib/BottomNavigation.js
@@ -108,9 +108,9 @@ export default class BottomNavigation extends React.Component {
     }
   }
 
-  componentWillUnmount() {
-    Dimensions.removeEventListener('change', this.handleDimensionChange)
-  }
+  // componentWillUnmount() {
+  //   Dimensions.removeEventListener('change', this.handleDimensionChange)
+  // }
 
   handleDimensionChange = () => {
     if (Device.isLandscape() && !this.state.isLandscape) {

This issue body was partially generated by patch-package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant