Skip to content

Upgrade to Svelte 5.0 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Upgrade to Svelte 5.0 #74

wants to merge 19 commits into from

Conversation

Greenfoot5
Copy link

@Greenfoot5 Greenfoot5 commented Apr 10, 2025

So, I've tried to upgrade everything, but have little experience with the project, so it's mainly me updating version numbers with some trial and error until it compiles.

What has been done?

  • Ran the Svelte upgrade script
  • Gone through each dependency and upgraded to the latest.
    • I know not the best, but I had another issue I thought was related to something being out of date
  • Checked it built and svelte-kit app works
  • I have moved from an older template to the vite + ts + svelte demo. The old one version was outdated, and the template has been archived.
  • I have updated the patch version number, I'm not sure if this should be 3.2.0 or 4.0.0, and set the patch to show it's different from previous.

Known Issues

  • I haven't extensively tested it (especially with other dependencies)
  • Svelte app doesn't compile. There's a circular import I haven't debugged
  • createEventDispatcher and afterUpdate are utilised still in Particles despite being depreciated.
    • I could do with some help here as I'm not sure how best to migrate this.
  • I'm not sure if I should be able to click the elements behind in the svelt-kit demo

Any assistance would be lovely in helping make this all works correctly. My next step is to try and get apps/svelte working

Copy link

coderabbitai bot commented Apr 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Greenfoot5 Greenfoot5 marked this pull request as draft April 10, 2025 15:31
@Greenfoot5 Greenfoot5 marked this pull request as ready for review April 13, 2025 12:42
@Greenfoot5
Copy link
Author

@matteobruni I haven't got anything else to add here, are you able to review it?

@Spacexplorer11
Copy link

I also want this to be compatible with Svelte 5 since it is causing issues since I'm using svelte 5. @matteobruni please review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants