Skip to content

fix(typeahead): typeahead prepareMatches method doesn't check for undefined observables #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielGz opened this issue Aug 26, 2017 · 1 comment

Comments

@danielGz
Copy link

danielGz commented Aug 26, 2017

I noticed that prepareMatches doesn't check when options = undefined, in cases when you're using an observable as input parameter to the directive and the observable returns a null object (such as when getting a 204 NO CONTENT from a service) the module crashes. Maybe there's a work around that doesn't involve modifying the directive code but I wanted to check first.

@valorkin
Copy link
Member

Nope, it is an issue to fix,
As a workaround always return something from Observables

@YevheniiaMazur YevheniiaMazur changed the title TypeAhead prepareMatches method doesn't check for undefined observables fix(typeahead): typeahead prepareMatches method doesn't check for undefined observables Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants