fix(datepicker): keep comp configuration updated (#5383) #5612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I made component's configuration to be always up to date.
Overview
Datepicker configuration composed with 4 parts:
We have to keep in mind, that any value that comes from Input can be changed any time.
Why issue happened
Configuration was recalculated (setConfig) only on ngOnInit() and on show() calls, therefore there are situations when calculated config was out of sync with updated input config properties.
Solution
I created config$ stream, that listens to every part of component's configuration and recalculates final config if any part updated . This way "_config" always reflects actual configuration state.