Skip to content

feat(create-vite): add @hiogawa/vite-rsc #20209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

hi-ogawa
Copy link
Collaborator

Description

This PR adds @hiogawa/vite-rsc's example to create-vite. I wrote a documentation in https://github.com/hi-ogawa/vite-plugins/tree/main/packages/rsc if anyone interested.

The example is conceptually an RSC equivalent of current React SPA templates (i.e. minimal React app on Vite using React API). Not only for Vite users, but I'm hoping that this can serve as a general RSC concept overview for wider React community. I'll probably have to communicate with Vite React framework folks separately, but I think having this included here makes it easier for me to spread the word for starter. Thanks for the consideration!

@hi-ogawa hi-ogawa marked this pull request as ready for review June 15, 2025 06:14
@sapphi-red sapphi-red added the feat: create-vite create-vite package label Jun 16, 2025
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add this

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for the Display name it could be more descriptive but couldn't find a good one to propose. Probably good to go with the repo name too for now

@hi-ogawa
Copy link
Collaborator Author

I talked with Evan and we might move this to vitejs org eventually. For now I'll do a little sharing and check with framework authors on my own and see how it goes, but later, I will propose something to make it look more official.

@patak-dev patak-dev merged commit 7cf0aff into vitejs:main Jun 16, 2025
16 checks passed
@hi-ogawa hi-ogawa deleted the feat-create-vite-rsc branch June 16, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: create-vite create-vite package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants