docs: mention bun.lock for lockfile
#20210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
reviewed
Jun 16, 2025
| @@ -70,7 +70,7 @@ You can further customize esbuild too with the [`optimizeDeps.esbuildOptions` op | |||
|
|
|||
| Vite caches the pre-bundled dependencies in `node_modules/.vite`. It determines whether it needs to re-run the pre-bundling step based on a few sources: | |||
|
|
|||
| - Package manager lockfile content, e.g. `package-lock.json`, `yarn.lock`, `pnpm-lock.yaml` or `bun.lockb`. | |||
| - Package manager lockfile content, e.g. `package-lock.json`, `yarn.lock`, `pnpm-lock.yaml`, `bun.lock` or `bun.lockb`. | |||
There was a problem hiding this comment.
Suggested change
| - Package manager lockfile content, e.g. `package-lock.json`, `yarn.lock`, `pnpm-lock.yaml`, `bun.lock` or `bun.lockb`. | |
| - Package manager lockfile content, e.g. `package-lock.json`, `yarn.lock`, `pnpm-lock.yaml` or `bun.lock` |
Since this list is just an example, I think it's fine to remove bun.lockb because bun.lock has been added instead.
There was a problem hiding this comment.
In that case, this PR is irrelevant because it's just an example. Either keep both or close this PR in my opinion
There was a problem hiding this comment.
@sapphi-red , @WarningImHack3r , with respect I want to tell one thing if you allow. I have seen in the codebase that both bun.lock and bun.lockb are present. Can't we add both here also then ?
vite/packages/vite/src/node/optimizer/index.ts
Line 1231 in 3bf3a8a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bun generates
bun.lockby default from bun v1.2. I think may be here we may addbun.lockwithbun.lockbas well.https://bun.sh/docs/install/lockfile