-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[v3] Make filtered dialog examples code work for linux #4287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Make filtered dialog examples code work for linux #4287
Conversation
WalkthroughThe update revises the internal logic of the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@bh90210 - Great to see you again! |
|
Amazing! 🚀 |
Description
Filters for file dialogs do not work as intended.
the above snippet is from
v3/examples/dialogs/main.go:l275
Right now it would produce an empty selection list for both filters.
I looked on github for C implementations of
gtk_file_filter_add_pattern
https://github.com/search?q=gtk_file_filter_add_pattern&type=code and indeed people seem to support the;
separator for patterns but it seems this is not something gtk does for you.Type of change
Please select the option that is relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor
.If you checked Linux, please specify the distro and version.
Test Configuration
wails doctor
▄ Scanning system - Please wait (this may take a long time)... (1s)^C⏎
byron@byron-X570-UD /m/w/wailsfork (bugfix/v3-alpha_linux-dialog-filter-pattern) [SIGINT]> wails3 doctor
Wails (v3.0.0-dev) Wails Doctor
System
WARNING: failed to read int from file: open /sys/devices/system/cpu/cpu0/online: no such file or directory
┌────────────────────────────────────────────────────────────────────────────────┐
| Name | Ubuntu |
| Version | 24.04 |
| ID | ubuntu |
| Branding | 24.04.2 LTS (Noble Numbat) |
| Platform | linux |
| Architecture | amd64 |
| CPU | AMD Ryzen 9 3900X 12-Core Processor |
| GPU 1 | Unknown |
| GPU 2 | TU116 [GeForce GTX 1660] (NVIDIA Corporation) - Driver: nvidia |
| Memory | 32GB |
└────────────────────────────────────────────────────────────────────────────────┘
Build Environment
┌─────────────────────────────────────────────────────────┐
| Wails CLI | v3.0.0-dev |
| Go Version | go1.24.0 |
| Revision | 2abd05f |
| Modified | false |
| -buildmode | exe |
| -compiler | gc |
| CGO_CFLAGS | -I/usr/local/cuda-11.8/include/ |
| CGO_CPPFLAGS | |
| CGO_CXXFLAGS | |
| CGO_ENABLED | 1 |
| CGO_LDFLAGS | |
| GOAMD64 | v1 |
| GOARCH | amd64 |
| GOOS | linux |
| vcs | git |
| vcs.modified | false |
| vcs.revision | 2abd05f |
| vcs.time | 2025-04-28T12:27:50Z |
└─────────────────────────────────────────────────────────┘
Dependencies
┌──────────────────────────────────────┐
| gtk3 | 3.24.41-4ubuntu1.3 |
| npm | 10.8.3 |
| pkg-config | 1.8.1-2build1 |
| webkit2gtk | 2.48.1-0ubuntu0.24.04.1 |
| gcc | 12.10ubuntu1 |
| |
└────── * - Optional Dependency ───────┘
Checking for issues
SUCCESS No issues found
Diagnosis
SUCCESS Your system is ready for Wails development!
Need documentation? Run: wails3 docs
♥ If Wails is useful to you or your company, please consider sponsoring the project: wails3 sponsor
Summary by CodeRabbit