Skip to content

feat(theme/sidebar): collapsible sidebar #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sepush
Copy link

@Sepush Sepush commented May 10, 2025

Summary

A shortcut to toggle the sidebar

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented May 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented May 10, 2025

Deploy Preview for rspress ready!

Name Link
🔨 Latest commit 631c1c6
🔍 Latest deploy log https://app.netlify.com/sites/rspress/deploys/681f504a95ac5000084345d3
😎 Deploy Preview https://deploy-preview-2142--rspress.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🔴 down 10 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sepush
Copy link
Author

Sepush commented May 10, 2025

rsp-cs.mp4

Copy link

netlify bot commented May 10, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 631c1c6
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/681f504a244ab900084ec61f
😎 Deploy Preview https://deploy-preview-2142--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JounQin
Copy link
Collaborator

JounQin commented May 10, 2025

The design is not quite harmonious IMO, and a new issue for discussion should be raised first before PR, and at least it should be an opt-in feature with a new option.

@Sepush
Copy link
Author

Sepush commented May 10, 2025

The design is not quite harmonious IMO, and a new issue for discussion should be raised first before PR, and at least it should be an opt-in feature with a new option.

Currently, this is just a prototype. I'll submit an issue first to discuss the design and get feedback. After that discussion, I'll refine this PR accordingly. For now, I'll mark this PR as a draft.

@Sepush Sepush marked this pull request as draft May 10, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants