Skip to content

Implemented month onChange to set the day count #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Implemented month onChange to set the day count #84

wants to merge 1 commit into from
+22 −3

Conversation

Trystanr
Copy link

@Trystanr Trystanr commented Sep 29, 2022 •
edited
Loading

Hi @whitphx

Thanks for the awesome package.

I noticed the package does not check for days of the month so I have added it.

I have only completed the implementation for the vanilla preset, but the other presets should be super simple.

This would close #20

Hope it helps!

@whitphx
Copy link
Owner

whitphx commented Nov 30, 2022

Thank you for having an interest in and contributing to this repository,
but let me reject this suggestion due to the following reasons.

  • Checking the number of days on each month has been done inside useDateSelect() and the invalid combinations of Y/M/D are represented with null value of the dateValue field returned from useDateSelect(), so it should not be done at the view component layer.
  • Logics should be inside the hook, not in the view component.

Thank you for your understanding.

@whitphx whitphx closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indicate invalid y-m-d combinations
2 participants
@Trystanr @whitphx