-
Notifications
You must be signed in to change notification settings - Fork 308
Replace Allegro release plugin by shipkit-auto-version #9149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~b7fca0b542, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.002 s) : 0, 1002233
Total [baseline] (8.596 s) : 0, 8596285
Agent [candidate] (1.005 s) : 0, 1005016
Total [candidate] (8.637 s) : 0, 8636833
section iast
Agent [baseline] (1.14 s) : 0, 1140248
Total [baseline] (9.327 s) : 0, 9327140
Agent [candidate] (1.143 s) : 0, 1142866
Total [candidate] (9.289 s) : 0, 9289414
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~b7fca0b542, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.496 ms) : 0, 692496
BytebuddyAgent [candidate] (694.017 ms) : 0, 694017
GlobalTracer [baseline] (243.494 ms) : 0, 243494
GlobalTracer [candidate] (244.292 ms) : 0, 244292
AppSec [baseline] (30.447 ms) : 0, 30447
AppSec [candidate] (30.707 ms) : 0, 30707
Debugger [baseline] (5.991 ms) : 0, 5991
Debugger [candidate] (6.076 ms) : 0, 6076
Remote Config [baseline] (677.636 µs) : 0, 678
Remote Config [candidate] (685.427 µs) : 0, 685
Telemetry [baseline] (8.215 ms) : 0, 8215
Telemetry [candidate] (8.348 ms) : 0, 8348
section iast
BytebuddyAgent [baseline] (814.304 ms) : 0, 814304
BytebuddyAgent [candidate] (815.584 ms) : 0, 815584
GlobalTracer [baseline] (233.081 ms) : 0, 233081
GlobalTracer [candidate] (233.722 ms) : 0, 233722
AppSec [baseline] (29.511 ms) : 0, 29511
AppSec [candidate] (29.161 ms) : 0, 29161
Debugger [baseline] (6.616 ms) : 0, 6616
Debugger [candidate] (5.79 ms) : 0, 5790
Remote Config [baseline] (581.741 µs) : 0, 582
Remote Config [candidate] (584.884 µs) : 0, 585
Telemetry [baseline] (7.908 ms) : 0, 7908
Telemetry [candidate] (8.006 ms) : 0, 8006
IAST [baseline] (27.46 ms) : 0, 27460
IAST [candidate] (29.203 ms) : 0, 29203
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~b7fca0b542, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1001469
Total [baseline] (10.557 s) : 0, 10557426
Agent [candidate] (996.292 ms) : 0, 996292
Total [candidate] (7.436 s) : 0, 7435812
section appsec
Agent [baseline] (1.176 s) : 0, 1175537
Total [baseline] (10.823 s) : 0, 10822624
Agent [candidate] (1.181 s) : 0, 1181027
Total [candidate] (9.195 s) : 0, 9194627
section iast
Agent [baseline] (1.132 s) : 0, 1131786
Total [baseline] (10.829 s) : 0, 10828846
Agent [candidate] (1.153 s) : 0, 1152705
Total [candidate] (11.163 s) : 0, 11162513
section profiling
Agent [baseline] (1.263 s) : 0, 1262788
Total [baseline] (11.099 s) : 0, 11099159
Agent [candidate] (1.251 s) : 0, 1251263
Total [candidate] (11.075 s) : 0, 11074549
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~b7fca0b542, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.604 ms) : 0, 691604
BytebuddyAgent [candidate] (687.439 ms) : 0, 687439
GlobalTracer [baseline] (243.563 ms) : 0, 243563
GlobalTracer [candidate] (242.632 ms) : 0, 242632
AppSec [baseline] (30.472 ms) : 0, 30472
AppSec [candidate] (30.411 ms) : 0, 30411
Debugger [baseline] (5.965 ms) : 0, 5965
Debugger [candidate] (6.064 ms) : 0, 6064
Remote Config [baseline] (670.122 µs) : 0, 670
Remote Config [candidate] (665.997 µs) : 0, 666
Telemetry [baseline] (8.294 ms) : 0, 8294
Telemetry [candidate] (8.144 ms) : 0, 8144
section appsec
BytebuddyAgent [baseline] (710.506 ms) : 0, 710506
BytebuddyAgent [candidate] (713.484 ms) : 0, 713484
GlobalTracer [baseline] (235.182 ms) : 0, 235182
GlobalTracer [candidate] (236.834 ms) : 0, 236834
IAST [baseline] (23.609 ms) : 0, 23609
IAST [candidate] (23.694 ms) : 0, 23694
AppSec [baseline] (171.043 ms) : 0, 171043
AppSec [candidate] (171.642 ms) : 0, 171642
Debugger [baseline] (5.708 ms) : 0, 5708
Debugger [candidate] (5.738 ms) : 0, 5738
Remote Config [baseline] (600.571 µs) : 0, 601
Remote Config [candidate] (577.596 µs) : 0, 578
Telemetry [baseline] (8.04 ms) : 0, 8040
Telemetry [candidate] (8.094 ms) : 0, 8094
section iast
BytebuddyAgent [baseline] (806.918 ms) : 0, 806918
BytebuddyAgent [candidate] (821.767 ms) : 0, 821767
GlobalTracer [baseline] (232.209 ms) : 0, 232209
GlobalTracer [candidate] (235.977 ms) : 0, 235977
IAST [baseline] (27.321 ms) : 0, 27321
IAST [candidate] (25.535 ms) : 0, 25535
AppSec [baseline] (30.285 ms) : 0, 30285
AppSec [candidate] (33.751 ms) : 0, 33751
Debugger [baseline] (5.755 ms) : 0, 5755
Debugger [candidate] (5.838 ms) : 0, 5838
Remote Config [baseline] (585.582 µs) : 0, 586
Remote Config [candidate] (592.903 µs) : 0, 593
Telemetry [baseline] (7.911 ms) : 0, 7911
Telemetry [candidate] (8.087 ms) : 0, 8087
section profiling
BytebuddyAgent [baseline] (687.679 ms) : 0, 687679
BytebuddyAgent [candidate] (680.954 ms) : 0, 680954
GlobalTracer [baseline] (365.138 ms) : 0, 365138
GlobalTracer [candidate] (363.634 ms) : 0, 363634
AppSec [baseline] (33.525 ms) : 0, 33525
AppSec [candidate] (32.608 ms) : 0, 32608
Debugger [baseline] (10.01 ms) : 0, 10010
Debugger [candidate] (11.458 ms) : 0, 11458
Remote Config [baseline] (683.915 µs) : 0, 684
Remote Config [candidate] (680.841 µs) : 0, 681
Telemetry [baseline] (9.782 ms) : 0, 9782
Telemetry [candidate] (8.818 ms) : 0, 8818
ProfilingAgent [baseline] (106.865 ms) : 0, 106865
ProfilingAgent [candidate] (104.214 ms) : 0, 104214
Profiling [baseline] (106.89 ms) : 0, 106890
Profiling [candidate] (104.239 ms) : 0, 104239
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~b7fca0b542, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section baseline
no_agent (4.383 ms) : 4327, 4440
. : milestone, 4383,
iast (9.489 ms) : 9329, 9650
. : milestone, 9489,
iast_FULL (14.12 ms) : 13840, 14400
. : milestone, 14120,
iast_GLOBAL (10.443 ms) : 10256, 10629
. : milestone, 10443,
profiling (8.438 ms) : 8296, 8580
. : milestone, 8438,
tracing (7.371 ms) : 7270, 7472
. : milestone, 7371,
section candidate
no_agent (4.251 ms) : 4199, 4304
. : milestone, 4251,
iast (9.301 ms) : 9150, 9453
. : milestone, 9301,
iast_FULL (14.063 ms) : 13784, 14343
. : milestone, 14063,
iast_GLOBAL (10.368 ms) : 10188, 10549
. : milestone, 10368,
profiling (8.584 ms) : 8453, 8716
. : milestone, 8584,
tracing (7.666 ms) : 7559, 7774
. : milestone, 7666,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~b7fca0b542, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section baseline
no_agent (37.366 ms) : 37066, 37666
. : milestone, 37366,
appsec (48.267 ms) : 47831, 48703
. : milestone, 48267,
code_origins (45.362 ms) : 44962, 45763
. : milestone, 45362,
iast (45.271 ms) : 44884, 45658
. : milestone, 45271,
profiling (48.465 ms) : 48029, 48901
. : milestone, 48465,
tracing (43.08 ms) : 42716, 43444
. : milestone, 43080,
section candidate
no_agent (37.86 ms) : 37561, 38160
. : milestone, 37860,
appsec (47.861 ms) : 47420, 48302
. : milestone, 47861,
code_origins (46.126 ms) : 45726, 46527
. : milestone, 46126,
iast (45.277 ms) : 44881, 45674
. : milestone, 45277,
profiling (49.028 ms) : 48564, 49491
. : milestone, 49028,
tracing (42.374 ms) : 42034, 42715
. : milestone, 42374,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~b7fca0b542, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section baseline
no_agent (15.446 s) : 15446000, 15446000
. : milestone, 15446000,
appsec (14.813 s) : 14813000, 14813000
. : milestone, 14813000,
iast (18.709 s) : 18709000, 18709000
. : milestone, 18709000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
. : milestone, 18054000,
profiling (15.407 s) : 15407000, 15407000
. : milestone, 15407000,
tracing (14.869 s) : 14869000, 14869000
. : milestone, 14869000,
section candidate
no_agent (15.306 s) : 15306000, 15306000
. : milestone, 15306000,
appsec (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
iast (18.164 s) : 18164000, 18164000
. : milestone, 18164000,
iast_GLOBAL (18.176 s) : 18176000, 18176000
. : milestone, 18176000,
profiling (14.951 s) : 14951000, 14951000
. : milestone, 14951000,
tracing (14.72 s) : 14720000, 14720000
. : milestone, 14720000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~b7fca0b542, baseline=1.52.0-SNAPSHOT~ad6d6b9786
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.4 ms) : 2350, 2449
. : milestone, 2400,
iast (2.185 ms) : 2123, 2248
. : milestone, 2185,
iast_GLOBAL (2.233 ms) : 2170, 2295
. : milestone, 2233,
profiling (2.056 ms) : 2004, 2108
. : milestone, 2056,
tracing (2.0 ms) : 1952, 2048
. : milestone, 2000,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.401 ms) : 2351, 2451
. : milestone, 2401,
iast (2.179 ms) : 2117, 2241
. : milestone, 2179,
iast_GLOBAL (2.233 ms) : 2170, 2295
. : milestone, 2233,
profiling (2.029 ms) : 1979, 2080
. : milestone, 2029,
tracing (2.004 ms) : 1955, 2052
. : milestone, 2004,
|
9a91793
to
41d0e2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just 2 minor nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it behave with ./gradlew release -Prelease.dryRun
for the release? Is the tag correct?
Co-authored-by: Alexey Kuznetsov <alexey.kuznetsov@datadoghq.com>
@PerfectSlayer I haven't worked yet the release process. I'm open to suggestions on this. Currently the release process makes use of commands the axion-release commands, usually it looks like this
Since we want to create a release by pushing a tag:
Note the listed alternatives also, don't have a "release" task. |
What Does This Do
Replace
pl.allegro.tech.build.axion-release
byorg.shipkit.shipkit-auto-version
to compute the version.Allegro has some performance issue when configuring the project, there's more recent version that we could leverage, but since the JVM is currently stuck to Java 8, so we cannot upgrade.
The
shipkit-auto-version
plugin uses aValueSource
API to be configuration cache compatible. Also, it uses under the hoodgit
binary instead of jgit.However, it has fewer options regarding version computation, like dirtiness, number of commits needed.
The plugin also explains, why it chose a version, e.g.
The task
writeVersionNumberFile
still work as expected. E.g. inagent-ci-visibiltiy
this will generate a fileagent-ci-visibility.version
with1.51.1-SNAPSHOT~9a9179389f
content.Other considered plugins
v1.51.0-11-g90a02ce.dirty
,v1.51.1.dirty
)Also this removes this buildscript hack around jsch dependency substitution introduced in #4197
Motivation
allegro release plugin on our current repo:
Full flamegraph with
pl.allegro.tech.build.axion-release
Versus shipkit-auto-version :
Full flamegraph with
shipkit-auto-version
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]