-
Notifications
You must be signed in to change notification settings - Fork 307
DSM optimizations - major refactoring to get rid of LinkedHashMap #9151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 42 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~4c28cbb640, baseline=1.52.0-SNAPSHOT~3abf3010b9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (994.167 ms) : 0, 994167
Total [baseline] (8.612 s) : 0, 8612323
Agent [candidate] (994.137 ms) : 0, 994137
Total [candidate] (8.579 s) : 0, 8579479
section iast
Agent [baseline] (1.135 s) : 0, 1135391
Total [baseline] (9.294 s) : 0, 9294137
Agent [candidate] (1.133 s) : 0, 1132991
Total [candidate] (9.297 s) : 0, 9297266
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~4c28cbb640, baseline=1.52.0-SNAPSHOT~3abf3010b9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.243 ms) : 0, 686243
BytebuddyAgent [candidate] (684.846 ms) : 0, 684846
GlobalTracer [baseline] (241.913 ms) : 0, 241913
GlobalTracer [candidate] (243.281 ms) : 0, 243281
AppSec [baseline] (30.343 ms) : 0, 30343
AppSec [candidate] (30.373 ms) : 0, 30373
Debugger [baseline] (6.002 ms) : 0, 6002
Debugger [candidate] (5.921 ms) : 0, 5921
Remote Config [baseline] (689.293 µs) : 0, 689
Remote Config [candidate] (695.111 µs) : 0, 695
Telemetry [baseline] (8.182 ms) : 0, 8182
Telemetry [candidate] (8.226 ms) : 0, 8226
section iast
BytebuddyAgent [baseline] (809.476 ms) : 0, 809476
BytebuddyAgent [candidate] (806.743 ms) : 0, 806743
GlobalTracer [baseline] (232.501 ms) : 0, 232501
GlobalTracer [candidate] (233.668 ms) : 0, 233668
IAST [baseline] (25.887 ms) : 0, 25887
IAST [candidate] (28.076 ms) : 0, 28076
AppSec [baseline] (31.461 ms) : 0, 31461
AppSec [candidate] (29.439 ms) : 0, 29439
Debugger [baseline] (6.653 ms) : 0, 6653
Debugger [candidate] (5.776 ms) : 0, 5776
Remote Config [baseline] (582.23 µs) : 0, 582
Remote Config [candidate] (602.305 µs) : 0, 602
Telemetry [baseline] (7.913 ms) : 0, 7913
Telemetry [candidate] (7.983 ms) : 0, 7983
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~4c28cbb640, baseline=1.52.0-SNAPSHOT~3abf3010b9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (992.982 ms) : 0, 992982
Total [baseline] (10.696 s) : 0, 10696042
Agent [candidate] (1.003 s) : 0, 1002959
Total [candidate] (10.679 s) : 0, 10678587
section appsec
Agent [baseline] (1.174 s) : 0, 1173870
Total [baseline] (10.835 s) : 0, 10834507
Agent [candidate] (1.176 s) : 0, 1175599
Total [candidate] (10.785 s) : 0, 10784961
section iast
Agent [baseline] (1.133 s) : 0, 1133259
Total [baseline] (10.854 s) : 0, 10854372
Agent [candidate] (1.136 s) : 0, 1135683
Total [candidate] (10.865 s) : 0, 10865499
section profiling
Agent [baseline] (1.246 s) : 0, 1246165
Total [baseline] (10.908 s) : 0, 10908195
Agent [candidate] (1.243 s) : 0, 1243359
Total [candidate] (10.945 s) : 0, 10944621
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~4c28cbb640, baseline=1.52.0-SNAPSHOT~3abf3010b9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.097 ms) : 0, 685097
BytebuddyAgent [candidate] (691.522 ms) : 0, 691522
GlobalTracer [baseline] (241.988 ms) : 0, 241988
GlobalTracer [candidate] (244.867 ms) : 0, 244867
AppSec [baseline] (30.138 ms) : 0, 30138
AppSec [candidate] (30.63 ms) : 0, 30630
Debugger [baseline] (5.976 ms) : 0, 5976
Debugger [candidate] (6.019 ms) : 0, 6019
Remote Config [baseline] (671.019 µs) : 0, 671
Remote Config [candidate] (702.884 µs) : 0, 703
Telemetry [baseline] (8.189 ms) : 0, 8189
Telemetry [candidate] (8.218 ms) : 0, 8218
section appsec
BytebuddyAgent [baseline] (708.556 ms) : 0, 708556
BytebuddyAgent [candidate] (708.568 ms) : 0, 708568
GlobalTracer [baseline] (235.313 ms) : 0, 235313
GlobalTracer [candidate] (236.894 ms) : 0, 236894
AppSec [baseline] (170.973 ms) : 0, 170973
AppSec [candidate] (171.444 ms) : 0, 171444
Debugger [baseline] (5.8 ms) : 0, 5800
Debugger [candidate] (5.7 ms) : 0, 5700
Remote Config [baseline] (611.687 µs) : 0, 612
Remote Config [candidate] (597.07 µs) : 0, 597
Telemetry [baseline] (8.148 ms) : 0, 8148
Telemetry [candidate] (8.006 ms) : 0, 8006
IAST [baseline] (23.537 ms) : 0, 23537
IAST [candidate] (23.446 ms) : 0, 23446
section iast
BytebuddyAgent [baseline] (806.706 ms) : 0, 806706
BytebuddyAgent [candidate] (808.307 ms) : 0, 808307
GlobalTracer [baseline] (233.163 ms) : 0, 233163
GlobalTracer [candidate] (234.393 ms) : 0, 234393
AppSec [baseline] (29.828 ms) : 0, 29828
AppSec [candidate] (30.344 ms) : 0, 30344
Debugger [baseline] (6.602 ms) : 0, 6602
Debugger [candidate] (5.794 ms) : 0, 5794
Remote Config [baseline] (586.068 µs) : 0, 586
Remote Config [candidate] (590.009 µs) : 0, 590
Telemetry [baseline] (7.967 ms) : 0, 7967
Telemetry [candidate] (7.982 ms) : 0, 7982
IAST [baseline] (27.455 ms) : 0, 27455
IAST [candidate] (27.324 ms) : 0, 27324
section profiling
ProfilingAgent [baseline] (103.248 ms) : 0, 103248
ProfilingAgent [candidate] (103.009 ms) : 0, 103009
BytebuddyAgent [baseline] (679.439 ms) : 0, 679439
BytebuddyAgent [candidate] (676.117 ms) : 0, 676117
GlobalTracer [baseline] (361.307 ms) : 0, 361307
GlobalTracer [candidate] (362.921 ms) : 0, 362921
AppSec [baseline] (31.785 ms) : 0, 31785
AppSec [candidate] (33.579 ms) : 0, 33579
Debugger [baseline] (12.723 ms) : 0, 12723
Debugger [candidate] (9.891 ms) : 0, 9891
Remote Config [baseline] (650.35 µs) : 0, 650
Remote Config [candidate] (662.197 µs) : 0, 662
Telemetry [baseline] (8.045 ms) : 0, 8045
Telemetry [candidate] (8.623 ms) : 0, 8623
Profiling [baseline] (103.272 ms) : 0, 103272
Profiling [candidate] (103.033 ms) : 0, 103033
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~4c28cbb640, baseline=1.52.0-SNAPSHOT~3abf3010b9
dateFormat X
axisFormat %s
section baseline
no_agent (37.668 ms) : 37371, 37965
. : milestone, 37668,
appsec (49.077 ms) : 48642, 49513
. : milestone, 49077,
code_origins (46.553 ms) : 46143, 46963
. : milestone, 46553,
iast (45.681 ms) : 45276, 46085
. : milestone, 45681,
profiling (48.624 ms) : 48155, 49092
. : milestone, 48624,
tracing (44.89 ms) : 44510, 45269
. : milestone, 44890,
section candidate
no_agent (36.823 ms) : 36524, 37122
. : milestone, 36823,
appsec (47.717 ms) : 47296, 48138
. : milestone, 47717,
code_origins (44.877 ms) : 44496, 45257
. : milestone, 44877,
iast (44.485 ms) : 44090, 44880
. : milestone, 44485,
profiling (47.488 ms) : 47079, 47898
. : milestone, 47488,
tracing (42.951 ms) : 42591, 43310
. : milestone, 42951,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~4c28cbb640, baseline=1.52.0-SNAPSHOT~3abf3010b9
dateFormat X
axisFormat %s
section baseline
no_agent (4.325 ms) : 4278, 4372
. : milestone, 4325,
iast (9.609 ms) : 9451, 9768
. : milestone, 9609,
iast_FULL (13.968 ms) : 13697, 14239
. : milestone, 13968,
iast_GLOBAL (10.218 ms) : 10038, 10397
. : milestone, 10218,
profiling (8.809 ms) : 8674, 8945
. : milestone, 8809,
tracing (7.604 ms) : 7488, 7719
. : milestone, 7604,
section candidate
no_agent (4.363 ms) : 4314, 4411
. : milestone, 4363,
iast (9.114 ms) : 8959, 9270
. : milestone, 9114,
iast_FULL (13.76 ms) : 13491, 14029
. : milestone, 13760,
iast_GLOBAL (10.256 ms) : 10075, 10436
. : milestone, 10256,
profiling (8.976 ms) : 8816, 9136
. : milestone, 8976,
tracing (7.968 ms) : 7853, 8082
. : milestone, 7968,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~4c28cbb640, baseline=1.52.0-SNAPSHOT~3abf3010b9
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.404 ms) : 2354, 2453
. : milestone, 2404,
iast (2.194 ms) : 2132, 2256
. : milestone, 2194,
iast_GLOBAL (2.235 ms) : 2172, 2298
. : milestone, 2235,
profiling (2.035 ms) : 1985, 2085
. : milestone, 2035,
tracing (2.026 ms) : 1977, 2075
. : milestone, 2026,
section candidate
no_agent (1.466 ms) : 1454, 1477
. : milestone, 1466,
appsec (2.4 ms) : 2351, 2450
. : milestone, 2400,
iast (2.182 ms) : 2120, 2244
. : milestone, 2182,
iast_GLOBAL (2.23 ms) : 2167, 2292
. : milestone, 2230,
profiling (2.035 ms) : 1985, 2085
. : milestone, 2035,
tracing (2.007 ms) : 1959, 2056
. : milestone, 2007,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~4c28cbb640, baseline=1.52.0-SNAPSHOT~3abf3010b9
dateFormat X
axisFormat %s
section baseline
no_agent (15.833 s) : 15833000, 15833000
. : milestone, 15833000,
appsec (14.857 s) : 14857000, 14857000
. : milestone, 14857000,
iast (18.579 s) : 18579000, 18579000
. : milestone, 18579000,
iast_GLOBAL (17.83 s) : 17830000, 17830000
. : milestone, 17830000,
profiling (15.41 s) : 15410000, 15410000
. : milestone, 15410000,
tracing (14.71 s) : 14710000, 14710000
. : milestone, 14710000,
section candidate
no_agent (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
appsec (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
iast (18.969 s) : 18969000, 18969000
. : milestone, 18969000,
iast_GLOBAL (17.737 s) : 17737000, 17737000
. : milestone, 17737000,
profiling (15.447 s) : 15447000, 15447000
. : milestone, 15447000,
tracing (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
|
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
This change is aimed to reduce DSM overhead by using a lightweight object instead of linked maps.
Introduced
DataStreamsTags
andDataStreamsTagsBuild
which are now used instead ofLinkedHashMap
.Updated all integrations and tests.
My tests show ~10% throughput increase with a significant latency decrease without increasing CPU load.
