FeatureForm: Update UN Association Display Spec
#934
+115
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikrw
commented
Jul 10, 2025
Comment on lines
+494
to
+496
| internal class AttachmentSizeLimitExceededException(val limit: Long) : Exception( | ||
| "Attachment size exceeds the limit of ${limit/1_000_000} MB" | ||
| ) |
There was a problem hiding this comment.
Unrelated to the primary objective of this PR, this is a small fix where the exception message was being shown in bytes instead of MB.
sorenoid
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #kotlin/6148
Description:
This PR updates the toolkit to follow the latest spec for displaying UNA properties and behavior.
Summary of changes:
Feature.refresh()is now called when navigating forward/backward to a feature to trigger any attribute rule changes. See apollo/1168.AttachmentSizeLimitExceededExceptionclass.Test data available in the linked issue.
Pre-merge Checklist