feat(hub-common): discussions v1 to v2 #1853

rweber-esri · 2025-04-03T03:13:22Z

Description:

This is the branch that includes all the work necessary to cut over from Discussions V1 to V2 APIs.

Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

tommybramble

No findings from the code review.

Just FYI, the documentation guide link in the PR description is broken for me. I'm assuming that is the same storybook I can see when I run the app locally, but wondering if I should be able to access that link.

rweber-esri · 2025-04-07T16:51:37Z

Just FYI, the documentation guide link in the PR description is broken for me. I'm assuming that is the same storybook I can see when I run the app locally, but wondering if I should be able to access that link.

Thanks for pointing that out @tommybramble, that's been outdated for some time. I've updated the PR template on this branch so that the Documentation Guide link points here. The URL change won't be reflected though until this PR merges.

github-actions · 2025-04-15T13:34:20Z

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

github-actions · 2025-04-21T13:33:04Z

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

juliannaeapicella

LGTM!

github-actions · 2025-04-28T13:37:00Z

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

… deprecated

This reverts commit 04d0534.

This reverts commit dd7ccfb.

…ma & uiSchema for group members affects: @esri/hub-common ISSUES CLOSED: 12787

affects: @esri/hub-common ISSUES CLOSED: 12787

…chemaDiscussionSettings uischem affects: @esri/hub-common ISSUES CLOSED: 12875

… Members, Group => Members & Gr affects: @esri/hub-common ISSUES CLOSED: 12913

#1868)

…pr-preview for this branch affects: @esri/hub-common

#1877)

…g for channels and renaming gro affects: @esri/hub-common ISSUES CLOSED: 12667

…panning all category:org channe affects: @esri/hub-common ISSUES CLOSED: 12667

…ntially being null affects: @esri/hub-common ISSUES CLOSED: 12667

…astActivity affects: @esri/hub-common ISSUES CLOSED: 12667

…rather that directly referencin affects: @esri/hub-common ISSUES CLOSED: 12667

…g/fetching posts using the Post affects: @esri/hub-common ISSUES CLOSED: 12667

affects: @esri/hub-common ISSUES CLOSED: 12667

… access a channel group's user affects: @esri/hub-common ISSUES CLOSED: 12667

… permissions when building grou affects: @esri/hub-common ISSUES CLOSED: 12667

…m group admin predicates affects: @esri/hub-common ISSUES CLOSED: 12667

affects: @esri/hub-common ISSUES CLOSED: 12667

…y fn affects: @esri/hub-common ISSUES CLOSED: 13549

…errors related to no filters be affects: @esri/hub-common ISSUES CLOSED: 12667

…a hubSearch affects: @esri/hub-common ISSUES CLOSED: 12667

…mine if the user is not authori affects: @esri/hub-common ISSUES CLOSED: 12667

affects: @esri/hub-common ISSUES CLOSED: 12667

rweber-esri changed the base branch from f/12668-add-entity-discussion-settings-schema to master April 3, 2025 03:16

rweber-esri force-pushed the f/discussions-v1-to-v2 branch 2 times, most recently from 264e70f to 6b127db Compare April 3, 2025 14:21

rweber-esri mentioned this pull request Apr 4, 2025

feat(hub-common): add entity discussion settings ui schema #1852

Merged

4 tasks

rweber-esri force-pushed the f/discussions-v1-to-v2 branch from 6b127db to 033647b Compare April 7, 2025 12:38

rweber-esri requested review from juliannaeapicella and tommybramble April 7, 2025 12:41

tommybramble approved these changes Apr 7, 2025

View reviewed changes

rweber-esri force-pushed the f/discussions-v1-to-v2 branch 3 times, most recently from 0232adf to df86b7c Compare April 11, 2025 20:04

github-actions bot added the Stale Stale issue - update or it will be closed label Apr 15, 2025

rweber-esri force-pushed the f/discussions-v1-to-v2 branch from df86b7c to 280f53f Compare April 15, 2025 16:58

github-actions bot removed the Stale Stale issue - update or it will be closed label Apr 16, 2025

github-actions bot added the Stale Stale issue - update or it will be closed label Apr 21, 2025

juliannaeapicella approved these changes Apr 21, 2025

View reviewed changes

github-actions bot removed the Stale Stale issue - update or it will be closed label Apr 22, 2025

rweber-esri force-pushed the f/discussions-v1-to-v2 branch 4 times, most recently from b5ae7dd to 67552b8 Compare April 24, 2025 12:54

rweber-esri changed the title ~~feat(hub-common): expose the allowed channel ids field in the entity …~~ feat(hub-common): discussions v1 to v2 Apr 24, 2025

github-actions bot added the Stale Stale issue - update or it will be closed label Apr 28, 2025

rweber-esri added Draft Draft PR or Issue (don't mark stale) and removed Stale Stale issue - update or it will be closed labels May 2, 2025

JoshCrozier force-pushed the master branch from 3091cdd to bfa1d0a Compare May 19, 2025 16:49

rweber-esri and others added 29 commits July 8, 2025 14:39

docs: update README.md to reflect that @esri/hub-discussions has been…

80d7ba8

… deprecated

Revert "refactor(hub-common): temp remove discussion api v1 tests"

cc4deca

This reverts commit 04d0534.

Revert "refactor(hub-common): temp remove discussion api v1 fns"

2e9328e

This reverts commit dd7ccfb.

feat(hub-common): expose moderate and owner roles in channel acl sche…

01ee58c

…ma & uiSchema for group members affects: @esri/hub-common ISSUES CLOSED: 12787

test(hub-common): update ChannelSchema.test.ts

55c48f9

affects: @esri/hub-common ISSUES CLOSED: 12787

test(hub-common): fix EntityUiSchemaDiscussionsSettings.test.ts

0ef1d67

affects: @esri/hub-common ISSUES CLOSED: 12787

feat(hub-common): add linkTarget=event to channel picker in EntityUiS…

3b1615f

…chemaDiscussionSettings uischem affects: @esri/hub-common ISSUES CLOSED: 12875

feat(hub-common): add Post option for Public => Authenticated, Org =>…

9bb7775

… Members, Group => Members & Gr affects: @esri/hub-common ISSUES CLOSED: 12913

feat(hub-common): updates the create and edit channel UISchemas to co… (

216f21e

#1868)

fix(hub-common): add a comment to force a rebuild to see if it fixes …

48d4f1e

…pr-preview for this branch affects: @esri/hub-common

feat(hub-common): users can create channels from the discussion setti… (

26d9af3

#1877)

feat(hub-common): expand filters supported by hubSearch when searchin…

7077aa7

…g for channels and renaming gro affects: @esri/hub-common ISSUES CLOSED: 12667

fix(hub-common): getChannelOrgIds returns a unique array of org ids s…

4531dac

…panning all category:org channe affects: @esri/hub-common ISSUES CLOSED: 12667

fix(hub-common): transformEntityToEditor accounts for blockWords pote…

8198f16

…ntially being null affects: @esri/hub-common ISSUES CLOSED: 12667

fix(hub-common): processChannelOptions supports sort field value of l…

61497da

…astActivity affects: @esri/hub-common ISSUES CLOSED: 12667

fix(hub-common): transformChannelToEntity uses getChannelAccess util …

a3bb500

…rather that directly referencin affects: @esri/hub-common ISSUES CLOSED: 12667

feat(hub-common): make sure IPost.channelId is not lost when searchin…

08b08d1

…g/fetching posts using the Post affects: @esri/hub-common ISSUES CLOSED: 12667

feat(hub-common): refactor getChannelUsersQuery to support channel ACL

5b7901d

affects: @esri/hub-common ISSUES CLOSED: 12667

fix(hub-common): getChannelUsersQuery handles cases where user cannot…

90a1b26

… access a channel group's user affects: @esri/hub-common ISSUES CLOSED: 12667

fix(hub-common): getChannelUsersQuery does not filter role: owner acl…

23e9ac6

… permissions when building grou affects: @esri/hub-common ISSUES CLOSED: 12667

fix(hub-common): getChannelUsersQuery filters duplicate usernames fro…

f17b9ec

…m group admin predicates affects: @esri/hub-common ISSUES CLOSED: 12667

test(hub-common): fix ts error in discussions/utils.ts

bec3067

affects: @esri/hub-common ISSUES CLOSED: 12667

test(hub-common): fix inaccessible group test for getChannelUsersQuer…

7649305

…y fn affects: @esri/hub-common ISSUES CLOSED: 13549

fix(hub-common): update channel picker catalog definition to resolve …

3039b51

…errors related to no filters be affects: @esri/hub-common ISSUES CLOSED: 12667

feat(hub-common): expose "role" filter when searching for channels vi…

98471c6

…a hubSearch affects: @esri/hub-common ISSUES CLOSED: 12667

feat(hub-common): add cannotCreatePostGroupsBlockedV2 method to deter…

3279565

…mine if the user is not authori affects: @esri/hub-common ISSUES CLOSED: 12667

test(hub-common): fix discussions/index.test.ts

2cebcd4

affects: @esri/hub-common ISSUES CLOSED: 12667

test(hub-common): fix discussions/index.test.ts

d75a63d

affects: @esri/hub-common ISSUES CLOSED: 12667

test(hub-common): remove f test modifier in index.test.ts

f2008df

affects: @esri/hub-common ISSUES CLOSED: 12667

rweber-esri force-pushed the f/discussions-v1-to-v2 branch from b1f97c5 to f2008df Compare July 8, 2025 18:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(hub-common): discussions v1 to v2 #1853

feat(hub-common): discussions v1 to v2 #1853

Uh oh!

rweber-esri commented Apr 3, 2025 •

edited

Loading

Uh oh!

tommybramble left a comment

Uh oh!

rweber-esri commented Apr 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 21, 2025

Uh oh!

juliannaeapicella left a comment

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

Uh oh!

feat(hub-common): discussions v1 to v2 #1853

Are you sure you want to change the base?

feat(hub-common): discussions v1 to v2 #1853

Uh oh!

Conversation

rweber-esri commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tommybramble left a comment

Choose a reason for hiding this comment

Uh oh!

rweber-esri commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 21, 2025

Uh oh!

juliannaeapicella left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

Uh oh!

rweber-esri commented Apr 3, 2025 •

edited

Loading

rweber-esri commented Apr 7, 2025 •

edited

Loading