Feat (hub-common): DCAT AP 3XX #1928
Conversation
…ove extensibility over time
…o accommodate new major version
| "dct:language": { | ||
| "@id": "{{ metadata.mdLang.countryCode.value “-” languageCode.value }}", | ||
| }, | ||
| "dcat:distribution": [ |
There was a problem hiding this comment.
This is the one field in the dataset template that we don't want to expose for configuration. Other feeds (dcat-us 1.1, dcat-ap 2.0.1, etc.) dynamically calculate the values of these distributions at the api level.
If a user manually goes in and adds "dcat:distribution": [...], then we throw them a bone and append their custom distributions to our default ones. However, we don't advertise the functionality.
|
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
|
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
|
@sansth1010 do we even need this PR any more? I'm pretty sure that we don't since we're not allowing configuration of DCAT-AP 3.0.0 yet |
|
@sonofflynn89 We do not need this PR and can be closed. Once we start work on editable dcat AP 3.0 template, we can start hub.js work. |
Description: Description: adding new major version (3XX) for DCAT AP feeds, also refactors feed template organization to make code reviews and edits more concise.
Part of: https://devtopia.esri.com/dc/hub/issues/13284
Instructions for testing: unit testing for new feed version, will be tested via feeds api more extensively
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependenciesas needed. CRITICAL our automated release system can not be counted on to updatepeerDependenciesso we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.