Next and Previous in Playlist Shortcuts #7593
Conversation
…in playlist, respectively. Update localization and shortcut files accordingly.
github-actions
bot
added
the
PR: waiting for review
There was a problem hiding this comment.
Like laid out in #2138 (comment)
When watching regular videos outside of a playlist shift+p should skip to the next video in the recommended section if autoplay is enabled
Note: autoplay will be hidden when the following setting is enabled: Settings -> distraction free -> watch page -> Hide recommended videos
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
Head branch was pushed to by a user without write access
|
Requested changes have been implemented, with the original PR message edited to reflect this. |
There was a problem hiding this comment.
The wording of "Next in playlist" doesnt fully cover what its actually doing. shift + n can also be used outside of a playlist.
Therefore im requesting changes to the wording of both Next and Previous in playlist (previous being changed too because of wording consistency).
I think its best to also make these changes in the code instead of changing only the user facing strings
…mments and localization text to reflect these changes
Head branch was pushed to by a user without write access
|
I clarified the language - function names are a bit more general now, but comments and user-facing text should clarify this functionality. I modified the suggested text a bit because it was a bit verbose for the help menu. Let me know if you think the text you requested is the better option. |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE and
absidue
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
Head branch was pushed to by a user without write access
static/locales/en-US.yaml
Outdated
| @@ -1217,3 +1217,5 @@ KeyboardShortcutPrompt: | |||
| Skip by Tenths: Skip through video by percentage (3 skips to 30% of duration) | |||
| Home: Seek to the beginning of the video | |||
| End: Seek to the end of the video | |||
| Skip to Next Video: Skip to the next video (when using a playlist or when autoplay is enabled) | |||
There was a problem hiding this comment.
Sorry I think the recommended bit needs to be included coz FT got 2 autoplay
| Skip to Next Video: Skip to the next video (when using a playlist or when autoplay is enabled) | |
| Skip to Next Video: Skip to the next video (inside a playlist or when Autoplay Recommended Videos enabled) |
There was a problem hiding this comment.
Makes sense
There was a problem hiding this comment.
@PikachuEXE actually i disagree. That setting can be off in the settings but an user can still watch a video and turn autoplay on manually in the player. It will be on for remainder of that watch session
So the user doesn't have to explicitly enable that setting in order for it to work
There was a problem hiding this comment.
OK I am fine with autoplay wording
The only question left is why autoplay is required to be on to play next recommended video
There was a problem hiding this comment.
I required autoplay because that was requested in the first response, but I'd be happy to change that if there's a consensus
There was a problem hiding this comment.
Hmm I see #2138 (comment) is saying
Should move to the next video. If you're using a playlist, will go to the next video of the playlist. If not using a playlist, it will move to the next YouTube suggested video
The YT suggested video can be disabled with Hide recommended videos (I forgot to test that
But does that care about autoplay enabled or not? I haven't tested this on Youtube
There was a problem hiding this comment.
When there are no recommended videos, the shortcut has no effect. On YouTube, the shortcut works whether or not autoplay is enabled. So to match up functionality I can remove any checking of autoplay if that sounds good
There was a problem hiding this comment.
Still new to contributing here so just trying get confirmation before I step on toes
There was a problem hiding this comment.
Yes let's follow YT behaviour since this is copying YT keyboard shortcuts :)
Head branch was pushed to by a user without write access
Co-authored-by: PikachuEXE <git@pikachuexe.net>
Head branch was pushed to by a user without write access
Co-authored-by: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>
Pull Request Type
Related issue
Closes #2138
Description
Implement "Shift+n" and "Shift+p" to skip to next and previous video in playlist, respectively. When outside of playlist with autoplay enabled, "Shift+n" skips to the next recommended video. Update localization and shortcut files accordingly.
Screenshots
No visible change
Testing
Desktop
Additional context
N/A