MacOSVersion: enable strong typing, expand tests #20108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This upgrades
MacOSVersion
totyped: strong
and adds tests to expand coverage to 100% for lines and branches. The changes outside ofMacOSVersion
are fixes for related type issues that were surfaced after expanding type signatures and upgrading the type sigil.This was originally part of some larger typing work (in Cask) but it may benefit #20096, so I figured I would extract this into its own PR to get it out sooner.