Skip to content

MacOSVersion: enable strong typing, expand tests #20108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

samford
Copy link
Member

@samford samford commented Jun 13, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This upgrades MacOSVersion to typed: strong and adds tests to expand coverage to 100% for lines and branches. The changes outside of MacOSVersion are fixes for related type issues that were surfaced after expanding type signatures and upgrading the type sigil.

This was originally part of some larger typing work (in Cask) but it may benefit #20096, so I figured I would extract this into its own PR to get it out sooner.

@samford samford changed the title MacOSVersion: enable strong typing MacOSVersion: enable strong typing, expand tests Jun 13, 2025
samford added 2 commits June 15, 2025 09:02
This adds tests to expand coverage of `MacOSVersion` to 100% for lines
and branches.
@samford samford force-pushed the macos_version-upgrade-type-sigil branch from 0f6ebd9 to ea57773 Compare June 15, 2025 13:10
@MikeMcQuaid MikeMcQuaid enabled auto-merge June 16, 2025 07:37
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 16, 2025
Merged via the queue into master with commit ad28cc7 Jun 16, 2025
33 checks passed
@MikeMcQuaid MikeMcQuaid deleted the macos_version-upgrade-type-sigil branch June 16, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants