Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This adds a meson.format file that mostly mirrors the projects meson style and a pre-commit hook to enforce this style. Some low-diff files are formatted.
Our meson files are already formatted mostly in a way that is consistent with what
meson format
can be configured to enforce. The added
meson.format
style is the best one I could come up withto produce the least diff.
By adding a formatter for meson files we are reducing the chore of:
There are some cases where
meson format
might introduce more code churn (e.g. not always formattingfiles
multiline). This can be manually worked around by adding a placeholder comment. Not sure yet if it's worth it. The diff for formatting everything is already quite small and I don't expect that meson files experience a lot of code churn with backports.Context
Formatter docs are available at https://mesonbuild.com/Commands.html#format.
cc @roberth for pre-commit stuff and @Ericson2314 wrt to meson.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.