Skip to content

fix: qwikloader.cjs missing in non esm environments #7727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Jul 14, 2025

What is it?

  • Bug

Description

Certain environements can't use preloader.mjs (e.g. jest 29 and below). So until we decide to officially not support cjs anymore, we need to also output the preloader as .cjs.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner July 14, 2025 19:25
Copy link

changeset-bot bot commented Jul 14, 2025

⚠️ No Changeset found

Latest commit: ca12642

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jul 14, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7727
npm i https://pkg.pr.new/@builder.io/qwik-city@7727
npm i https://pkg.pr.new/eslint-plugin-qwik@7727
npm i https://pkg.pr.new/create-qwik@7727

commit: ca12642

Copy link
Contributor

github-actions bot commented Jul 14, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview ca12642

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 07c59ee into QwikDev:main Jul 14, 2025
19 checks passed
@maiieul maiieul moved this from Backlog to Done in Qwik Development Jul 15, 2025
@maiieul maiieul self-assigned this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants