fix(@schematics/angular): correctly detect modules using new file extension format #30471
+46
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
…ension format Previously, some internal methods failed to locate modules when using the `-module.ts` filename pattern instead of the legacy `.module.ts`. This update ensures proper detection with the new format.
alan-agius4
force-pushed
the
module-ext-search
branch
from
21f8cf5 to
1de653b
Compare
clydin
approved these changes
Jun 5, 2025
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 20.0.x |
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 5, 2025
Angular CLI generates `-module.ts` suffix when using `--standalone: false`. Our schematic tests generate the same, and fail currently because some files weren't picked up properly by the rule. This commit fixes this, and adds supports for the new suffix in a naive way until angular/angular-cli#30471 is available.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 5, 2025
Angular CLI generates `-module.ts` suffix when using `--standalone: false`. Our schematic tests generate the same, and fail currently because some files weren't picked up properly by the rule. This commit fixes this, and adds supports for the new suffix in a naive way until angular/angular-cli#30471 is available.
devversion
added a commit
to angular/components
that referenced
this pull request
Jun 5, 2025
Angular CLI generates `-module.ts` suffix when using `--standalone: false`. Our schematic tests generate the same, and fail currently because some files weren't picked up properly by the rule. This commit fixes this, and adds supports for the new suffix in a naive way until angular/angular-cli#30471 is available.
devversion
added a commit
to angular/components
that referenced
this pull request
Jun 5, 2025
Angular CLI generates `-module.ts` suffix when using `--standalone: false`. Our schematic tests generate the same, and fail currently because some files weren't picked up properly by the rule. This commit fixes this, and adds supports for the new suffix in a naive way until angular/angular-cli#30471 is available. (cherry picked from commit 394336c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some internal methods failed to locate modules when using the
-module.tsfilename pattern instead of the legacy.module.ts. This update ensures proper detection with the new format.