Skip to content

Conversation

johnpoth
Copy link
Member

…ass to inherit from Jline's Nano class

Needs jline/jline3#1199

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@johnpoth
Copy link
Member Author

Closing in favor of jline/jline3#1195 as it moves over the box drawing parts over to JLine which means even less maintenance for Camel

@gnodet gnodet marked this pull request as ready for review May 9, 2025 21:41
@gnodet
Copy link
Contributor

gnodet commented May 9, 2025

Update to leverage JLine 3.30.0 with the new support for suggestions, thx to @johnpoth

@apache apache deleted a comment May 10, 2025
@davsclaus davsclaus merged commit 12f7f3a into apache:main May 11, 2025
4 checks passed
@johnpoth johnpoth deleted the lsp branch May 13, 2025 09:43
vineetsaurabh pushed a commit to vineetsaurabh/camel that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants