-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-28903: Skip deleting archived path when drop partition/table #5769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding tests for this.
...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1 (pending tests)
|
What changes were proposed in this pull request?
When drop archived partition/table, only the original path of partition should be considered as a deletion candidate
Why are the changes needed?
Hadoop archived path is not supported to be deleted, in current implement the drop_partition/table calls would drop metadata successfully but throw exception when deleting the archived paths.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
mvn test -pl itests/qtest -Pitests -Dtest=org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver -Dqfile=archive_drop.q