Skip to content

HIVE-28923: Clean up dummy RawStores #5784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025

Conversation

dengzhhu653
Copy link
Member

What changes were proposed in this pull request?

Why are the changes needed?

every time the RawStore introduces a new method, all of them needs to implement it, however this is meaningless as no where would this new method be used.

Does this PR introduce any user-facing change?

no

How was this patch tested?

current tests

@dengzhhu653 dengzhhu653 changed the title HIVE-28923: Clean up dummy RawStores in the unit test HIVE-28923: Clean up dummy RawStores in the test Apr 24, 2025
Copy link

@dengzhhu653 dengzhhu653 changed the title HIVE-28923: Clean up dummy RawStores in the test HIVE-28923: Clean up dummy RawStores Apr 28, 2025
Copy link
Contributor

@SourabhBadhya SourabhBadhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@dengzhhu653 dengzhhu653 merged commit 8222107 into apache:master May 4, 2025
4 checks passed
@dengzhhu653 dengzhhu653 deleted the HIVE-28923 branch May 4, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants