HIVE-28934: PlanUtils.configureJobPropertiesForStorageHandler should use hive session configuration. #5788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
…use hive session configuration.
|
|
LGTM +1 |
simhadri-g
approved these changes
May 4, 2025
|
thanks @vrozov for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use session configuration to create
storageHandlerinPlanUtils.configureJobPropertiesForStorageHandler()instead of instantiatingHiveand using it to get configuration.Why are the changes needed?
Creating new instance of
Hiveis a heavy weight operation and it does not give correct HiveConf anyway.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests