HIVE-28920: Unstable tests due to unixtimestamp() and constant folding #5799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbo_join_transitive_pred_loop_1.q currently (2025-05-02) fails and the rest may fail if plan changes slighlty.
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
|
soumyakanti3578
approved these changes
May 2, 2025
|
Thanks for the reviews @soumyakanti3578 and @SourabhBadhya ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request and why?
Use
hive.test.currenttimestampinstead of regex masking to stabilize tests and avoid test failures and flakiness. Plans are subject to change anytime so instead of adapting the masking expression every-time it is preferred to use a fixed value for unixtimestamp() specific tests.Does this PR introduce any user-facing change?
No
How was this patch tested?