[ZEPPELIN-6185] fix prevent shortcut working in input field #4925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM.
|
|
@sh1nj1 Can you answer the question in Jira or should I transfer it to GitHub? |
|
I answered, I think it is better to fix first. |
Reamer
approved these changes
Jun 6, 2025
|
@sh1nj1 |
sh1nj1
force-pushed
the
fix/shortcut-in-text-field
branch
from
45ec7bf to
8b1745d
Compare
|
@Reamer rebased |
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jun 10, 2025
### What is this PR for? This PR fixes an issue that prevents entering shortcut characters in input fields. When using a dynamic input field, characters like 'l', 'b', etc., are treated as shortcuts and cannot be entered. This fix prevents shortcut actions from being triggered when the focused element is an input field. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-6185 ### How should this be tested? * Create new notebook using dynamic input field * Enter 'l' character and see if it is not working as shortcut(toggling line numbers) ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4925 from sh1nj1/fix/shortcut-in-text-field. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com> (cherry picked from commit 94ae845) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
|
@sh1nj1 Thanks for your contribution. I have created the following ticket to standardize the shortcuts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR fixes an issue that prevents entering shortcut characters in input fields.
When using a dynamic input field, characters like 'l', 'b', etc., are treated as shortcuts and cannot be entered.
This fix prevents shortcut actions from being triggered when the focused element is an input field.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: