Promote an assert! to a bail!
#2071
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a runtime assertion tripping to instead being a first-class error returned by `bail!`. This cannot currently be triggered from the CLI and is only reachable through API usage of the `wit_parser::Resolve` type. This usage is reachable through generators such as `wit_bindgen::generate!`, though. The error here happens when a package is re-added to a `Resolve` twice. This currently isn't supported and would require some large refactoring to support. This should probably be fixed at some point in the future to actually be supported but until that happens it's best to have a first-class error for this case instead of an internal assertion tripping. Closes bytecodealliance#1996
abrown
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a runtime assertion tripping to instead being a first-class error returned by
bail!. This cannot currently be triggered from the CLI and is only reachable through API usage of thewit_parser::Resolvetype. This usage is reachable through generators such aswit_bindgen::generate!, though.The error here happens when a package is re-added to a
Resolvetwice. This currently isn't supported and would require some large refactoring to support. This should probably be fixed at some point in the future to actually be supported but until that happens it's best to have a first-class error for this case instead of an internal assertion tripping.Closes #1996