`--emit-clif` files do not include function names

[MonoidMusician]

The IR included in explore includes function names with each section of IR, but this info doesn't end up in the similar files produced by --emit-clif which makes it hard to see what each function is (without cross-referencing with the explore output or something).

[jameysharp]

As the person who asked you to open this issue, I want to add a couple details for whoever has time to poke at it:

wasmtime explore gets the function name here:

wasmtime/crates/explorer/src/lib.rs

Lines 222 to 231 in ede670d

	let demangled_name = if let Some(name) = &function.name {
	let mut demangled = String::new();
	if demangle_function_name(&mut demangled, &name).is_ok() {
	Some(demangled)
	} else {
	None
	}
	} else {
	None
	};

The implementation of --emit-clif is here:

wasmtime/crates/cranelift/src/compiler.rs

Lines 1000 to 1004 in a4700cb

	let mut path = path.join(clif_filename);
	path.set_extension("clif");
	let mut output = std::fs::File::create(path).unwrap();
	write!(output, "{}", context.func.display()).unwrap();

In addition to explore, tests/disas.rs also uses emit-clif internally and IIRC also wants function names, so maybe this can all be unified a bit.

[PhantomInTheWire]

hey @alexcrichton! This looks like a good first issue! I think I have a solution for this. Could you please assign it to me?

[alexcrichton]

Sure thing, and one thing to be aware of perhaps is that #10947 just landed which changed things slightly in this area, but I believe this is still applicable with respect to wasmtime explore.

[PhantomInTheWire]

Awesome, thanks for assigning it! I'll dig into this