Skip to content

Conversation

@alexcrichton
Copy link
Member

My take on

git log `git merge-base HEAD origin/release-33.0.0`...HEAD

@alexcrichton alexcrichton requested a review from a team as a code owner June 9, 2025 15:13
@alexcrichton alexcrichton requested review from cfallin and removed request for a team June 9, 2025 15:13
to recognize it.
[#10813](https://github.com/bytecodealliance/wasmtime/pull/10813)

* The wasi-http implementation no longer generates a trap if the handle to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The wasi-http implementation no longer generates a trap if the handle to
* The wasi-http implementation responds with a 500 server error if the handle to

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I believe that this is the other way around, where for the embedder API if the channel to receive the response is dropped then previously response-outparam.set would generate a trap but now it just ignores the error. So this is more of a guest-side change than a host-side change (e.g. as it relates to wasmtime serve)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go ahead and land without this change, but happy to follow-up of course

@github-actions github-actions bot added the wasmtime:docs Issues related to Wasmtime's documentation label Jun 9, 2025
@alexcrichton alexcrichton merged commit b3ae195 into bytecodealliance:release-34.0.0 Jun 10, 2025
160 checks passed
@alexcrichton alexcrichton deleted the release-34.0.0 branch June 10, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:docs Issues related to Wasmtime's documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants