Minor updates to testing in Miri #10999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexcrichton
commented
Jun 10, 2025
alexcrichton
commented
- Use Pulley by default when Miri is enabled.
- Fail wasm module compilation with functions by default in Miri to prevent accidentally having super slow test in CI.
- Update some tests from fallout of the above two points, also ignore a slow test in Pulley.
* Use Pulley by default when Miri is enabled. * Fail wasm module compilation with functions by default in Miri to prevent accidentally having super slow test in CI. * Update some tests from fallout of the above two points, also ignore a slow test in Pulley. prtest:miri
pchickey
approved these changes
Jun 10, 2025
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
* Use Pulley by default when Miri is enabled. * Fail wasm module compilation with functions by default in Miri to prevent accidentally having super slow test in CI. * Update some tests from fallout of the above two points, also ignore a slow test in Pulley. prtest:miri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.