aarch64: Remove closure from Inst::load_constant
#11000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in bytecodealliance#5366 but upon reflection I don't think that it's necessary as almost all of the definitions reuse the temporary register as the destination register as well. The original motivation looks like it's relate to the SSA-ness of instructions but I believe the way it's generated it's all SSA-valid, so this commit removes the temp allocation function and uses `rd`, the destination register, unconditionally instead.
fitzgen
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #5366 but upon reflection I don't think that it's necessary as almost all of the definitions reuse the temporary register as the destination register as well. The original motivation looks like it's relate to the SSA-ness of instructions but I believe the way it's generated it's all SSA-valid, so this commit removes the temp allocation function and uses
rd, the destination register, unconditionally instead.