x64: Delete MovRR instruction variant #11025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Jun 12, 2025
Comment on lines
2679
to
2682
| let inst = asm::inst::movq_mr::new( | ||
| temp.map(Gpr::unwrap_new), | ||
| Gpr::unwrap_new(dst_old.to_reg()), | ||
| ) | ||
| .into(); | ||
| Inst::External { inst }.emit(sink, info, state); |
There was a problem hiding this comment.
Would be nice to have an emit_asm helper or something so that every call site doesn't need to do the whole .into(); Inst::External { inst }.emit(...) dance. Because the new version of everything here is a lot harder to read.
There was a problem hiding this comment.
I mentioned this in the OP but while some impedance mismatch is what you mention another big source is using Reg in pseudo-insts instead of Gpr. I'll work on a follow-up to try to fix that.
github-actions
bot
added
cranelift
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
alexcrichton
force-pushed
the
x64-rm-movrr
branch
from
9325ac1 to
403d951
Compare
alexcrichton
force-pushed
the
x64-rm-movrr
branch
from
403d951 to
05a6fc8
Compare
This removes `MovRR` and no new instructions were needed in the assembler as everything was already added. Lots of little updates here and there but everything pretty straightforward. Much of the conversion goop should get better over time as preexisting instructions should move to `Gpr` instead of `Reg` which would avoid the need for conversions at all.
alexcrichton
force-pushed
the
x64-rm-movrr
branch
from
05a6fc8 to
688cb47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
MovRRand no new instructions were needed in theassembler as everything was already added. Lots of little updates here
and there but everything pretty straightforward. Much of the conversion
goop should get better over time as preexisting instructions should move
to
Gprinstead ofRegwhich would avoid the need for conversions atall.