Update all id parameters to use guids instead of strings as datatypes closes #125 #126
Conversation
…r all `Id` input parameters from [String] to [Guid] #125 Updated parameter types for WorkspaceId and LakehouseId to GUID in multiple scripts to ensure better validation and consistency across the codebase. This change enhances the robustness of the functions by enforcing the correct data type. Thank you!
…spaceId, ReflexId, ReportId, and other identifiers - Updated parameter types from [string] to [guid] in multiple scripts across the Public/Reflex, Public/Report, Public/Restore Points, Public/SQL Database, Public/Spark, Public/Tenant, Public/Users, Public/Utils, Public/Warehouse, and Public/Workspace directories. - This change enhances type safety and ensures that only valid GUIDs are accepted for these parameters.
Updated the `WorkspaceId`, `CapacitiesIds`, and various other parameters to use the GUID datatype for consistency and improved type safety. This change enhances the clarity and reliability of the code. Thank you!
Corrected the conditional check for itemID to ensure proper functionality. This change enhances the reliability of the function when exporting items from a Fabric workspace. Thank you!
Linux Test Results4 887 tests 4 886 ✅ 41s ⏱️ Results for commit 64295db. ♻️ This comment has been updated with latest results. |
WinPS51 Test Results5 092 tests 5 091 ✅ 51s ⏱️ Results for commit 64295db. ♻️ This comment has been updated with latest results. |
WinPS71 Test Results5 092 tests 5 091 ✅ 52s ⏱️ Results for commit 64295db. ♻️ This comment has been updated with latest results. |
|
This looks good, thanks for implementing Rob! |
This commit introduces a new test suite to verify that function parameters ending with 'id' are of type System.Guid. This ensures consistency and correctness in parameter types across the module. Thank you!
Added tests as requested
All tests passing locally build succeeeding |
|
Looks good to me. Great job! |
|
@SQLDBAWithABeard - think from merging #128 in we got a conflict here - shout if you want me to look into it |
Updated the WorkspaceId parameter type from string to GUID for better validation and to ensure correct input format. This change enhances the function's robustness and prevents potential errors. Thank you!
|
Thank you @jpomfret - I missed merging develop back into the branch for this one. I have done it locally and pushed so it now needs approval for latest commit |
|
Thank you both |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in FabricTools-FeatureRelease
Pull Request
Update all id parameters to use guids instead of strings as datatypes closes #125
Pull Request (PR) description
No logic altered.
Updated the
WorkspaceId,CapacitiesIds,CapacityId,CopyJobId,datamartId,DataPipelineId,DataWarehouseGUID,DomainId,EnvironmentId,EventhouseId,EventstreamId,ExternalDataShareId,ItemId,KQLDashboardId,KQLDatabaseId,KQLQuerysetId,LakehouseId,MirroredDatabaseId,MirroredWarehouseId,MLExperimentId,MLModelId,NotebookId,operationId,PaginatedReportId,ParentDomainId,parentEventhouseId,PrincipalId,ReflexId,ReportId,SemanticModelId,SparkCustomPoolId,SparkJobDefinitionId,SQLDatabaseId,SQLEndpointId,subscriptionID,UserId,WarehouseId,WorkspaceGUID,WorkspaceId,WorkspaceIds,andWorkspaceRoleAssignmentIdparameters to the datatype GUIDTask list
[ X] The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
[X ] Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
[ X] Local clean build passes without issue or fail tests (
build.ps1 -ResolveDependency -Tasks build, test).[X ] Code follows the contribution guidelines.