-
Notifications
You must be signed in to change notification settings - Fork 311
Enable IL trimming and NativeAOT on AzureKeyVaultProvider #3401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.../AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3401 +/- ##
==========================================
- Coverage 65.34% 61.86% -3.49%
==========================================
Files 300 295 -5
Lines 65603 65321 -282
==========================================
- Hits 42871 40412 -2459
- Misses 22732 24909 +2177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to run this through our "official" AKV provider pipeline before accepting it - let me kick it off and see what we get. I'm guessing it'll be fine, but since I wrote the new AKV official pipeline, I just want to double check.
No changes required, just want to hold it until I can run the check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
We can safely enable IL trimming and NativeAOT support on the AzureKeyVaultProvider project for the .NET targets. This PR simply sets the
IsTrimmable
andIsAotCompatible
properties.This doesn't enable these features on SqlClient itself, and the addon isn't particularly useful on its own - but when the library itself is compatible, the addon isn't going to hold it back.
Issues
Relates to #1947.
Testing
The IL trimming and NativeAOT support is mostly flagged by compile-time warnings. A sample application which directly references the DLL runs successfully - I can successfully publish and run the code below.
I've not added a unit test - as per dotnet/runtime#97013 this isn't a good way to perform testing.