Refactor database explorer resource builders to not prefix their names the name of the first resource they are added to.

[paulomorgado]

Description

Refactor database explorer resource builders to not prefix their names the name of the first resource they are added to.

Kept the behavior where, when a containerName is passed, that's the one that is used.

Fixes #2060

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Is this introducing a breaking change?
      • Yes
        • Link to aspire-docs issue (please use this breaking-change template):
      • No
        • Link to aspire-docs issue (please use this doc-idea template):
  • No
  • Probably

[davidfowl]

@paulomorgado You might need to follow the pattern here

aspire/src/Aspire.Hosting.Azure.Functions/AzureFunctionsProjectResourceExtensions.cs

Lines 230 to 234 in 8ad1d4b

	private static string CreateDefaultStorageName(this IDistributedApplicationBuilder builder)
	{
	var applicationHash = builder.Configuration["AppHost:Sha256"]![..5].ToLowerInvariant();
	return $"{DefaultAzureFunctionsHostStorageName}{applicationHash}";
	}

This is to avoid conflicts with differnet apphosts.

[paulomorgado]

@paulomorgado You might need to follow the pattern here

aspire/src/Aspire.Hosting.Azure.Functions/AzureFunctionsProjectResourceExtensions.cs

Lines 230 to 234 in 8ad1d4b

	private static string CreateDefaultStorageName(this IDistributedApplicationBuilder builder)
	{
	var applicationHash = builder.Configuration["AppHost:Sha256"]![..5].ToLowerInvariant();
	return $"{DefaultAzureFunctionsHostStorageName}{applicationHash}";
	}

This is to avoid conflicts with differnet apphosts.

I'm sorry @davidfowl, but I don't get what you mean. I only changed the resource name, which is internal only to each instance of app host.

[davidfowl]

You're right. I guess there's no volume associated here.

[sebastienros]

when a containerName is passed, that's the one that is used.

Isn't it the current behavior? And if none is passed then a unique name is created by using the initiating resource.

Now with you PR two resources will have the same name if containerName is not set, meaning you have to set it if you have at least two. That might be ok but that's an insidious breaking change.

[paulomorgado]

@sebastienros,

Isn't it the current behavior? And if none is passed then a unique name is created by using the initiating resource.

No. If none is passed, the name is dependent on the name of the first resource adding this dependency.

Now with you PR two resources will have the same name if containerName is not set, meaning you have to set it if you have at least two. That might be ok but that's an insidious breaking change.

There will only be 1 and only 1 resource of these. there's no way of duplicating the names that was not possible before.

[paulomorgado]

@davidfowl, @sebastienros,

Is there anything missing here?

[sebastienros]

I will take another look, assigning to 9.3 so I don't forget

[sebastienros]

I reverted the changes for Milvus and MongoDB because they won't handle multiple calls (two resources are then declared with the same name). You can test it too, I did, and if you look at the other implementations (PgWeb, PhpMyAdmin, ...) where you did the change, you can see that the second call of the method return the existing container if there is one, so these work fine. These will also handle resources coming from other builders, meaning that if you create multiple dbs, a single explorer will render all these dbs.