Skip to content

Make verify tool accessible to the coding agent #9778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

radical
Copy link
Member

@radical radical commented Jun 9, 2025

  • Make verify tool accessible to the coding agent
  • Add dotnet and tools to PATH

This was reverted in #9775 because it failed with:

Run dotnet tool install --global Verify.Tool --version 0.6.0
The command could not be loaded, possibly because:
  * You intended to execute a .NET application:
      The application 'tool' does not exist.
  * You intended to execute a .NET SDK command:
      A compatible .NET SDK was not found.

Requested SDK version: 9.0.200
global.json file: /home/runner/work/aspire/aspire/global.json

Installed SDKs:

Install the [9.0.200] .NET SDK or update [/home/runner/work/aspire/aspire/global.json] to match an installed SDK.

Learn about SDK resolution:
https://aka.ms/dotnet/sdk-not-found
8.0.116 [/usr/lib/dotnet/sdk]

@github-actions github-actions bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Jun 9, 2025
@radical radical marked this pull request as ready for review June 9, 2025 21:27
@radical
Copy link
Member Author

radical commented Jun 9, 2025

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the Verify tool accessible to the coding agent and updates the PATH to include required dotnet tool locations, as well as enhancing the documentation for snapshot testing.

  • Introduces a new workflow step to install the Verify tool.
  • Adds a PATH setup step to include dotnet tool directories.
  • Updates the documentation to outline how snapshot testing is performed using the Verify tool.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/copilot-setup-steps.yml Adds steps to install the Verify tool and update PATH directories.
.github/copilot-instructions.md Documents the usage of the Verify tool for snapshot testing.
Comments suppressed due to low confidence (1)

.github/workflows/copilot-setup-steps.yml:29

  • [nitpick] Suppressing errors with '|| true' may hide issues during installation of the Verify tool; consider capturing and logging errors to aid debugging if the installation fails.
-        run: ./dotnet.sh tool install --global Verify.Tool --version 0.6.0 || true

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Build Analysis is hanging due to dotnet/dnceng#5442

TL;DR: Build Analysis depends on AzDo build to say "I'm done" to start doing its checks but given AzDO build was skipped here, then this causes build analysis to wait forever.

@joperezr joperezr merged commit 308b250 into dotnet:main Jun 9, 2025
251 of 252 checks passed
@joperezr
Copy link
Member

joperezr commented Jun 9, 2025

/ba-g

@radical radical deleted the copilot-verify-step branch June 9, 2025 22:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants