-
Notifications
You must be signed in to change notification settings - Fork 669
Make verify tool accessible to the coding agent #9778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes the Verify tool accessible to the coding agent and updates the PATH to include required dotnet tool locations, as well as enhancing the documentation for snapshot testing.
- Introduces a new workflow step to install the Verify tool.
- Adds a PATH setup step to include dotnet tool directories.
- Updates the documentation to outline how snapshot testing is performed using the Verify tool.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
.github/workflows/copilot-setup-steps.yml | Adds steps to install the Verify tool and update PATH directories. |
.github/copilot-instructions.md | Documents the usage of the Verify tool for snapshot testing. |
Comments suppressed due to low confidence (1)
.github/workflows/copilot-setup-steps.yml:29
- [nitpick] Suppressing errors with '|| true' may hide issues during installation of the Verify tool; consider capturing and logging errors to aid debugging if the installation fails.
- run: ./dotnet.sh tool install --global Verify.Tool --version 0.6.0 || true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Build Analysis is hanging due to dotnet/dnceng#5442
TL;DR: Build Analysis depends on AzDo build to say "I'm done" to start doing its checks but given AzDO build was skipped here, then this causes build analysis to wait forever.
/ba-g |
This was reverted in #9775 because it failed with: