Skip to content

Fix ACA DataProtection #9786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix ACA DataProtection #9786

merged 1 commit into from
Jun 10, 2025

Conversation

eerhardt
Copy link
Member

#9777 put the setting in the wrong spot. Instead of going directly under "properties", the "runtime" node needs to go under "properties/configuration".

Fix #8005

dotnet#9777 put the setting in the wrong spot. Instead of going directly under "properties", the "runtime" node needs to go under "properties/configuration".

Fix dotnet#8005
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jun 10, 2025
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@davidfowl
Copy link
Member

We're going to need to bump figure out how to automate a deployment smoke test.

@eerhardt
Copy link
Member Author

We're going to need to bump figure out how to automate a deployment smoke test.

Another thought is to run a bicep linter on our bicep - maybe in the playground apps or something. That would have caught this issue at least.

But I agree the real fix here is to deploy the bicep to Azure for real. But how much? Every bicep file we produce in all our tests? All the playground apps?

@eerhardt eerhardt enabled auto-merge (squash) June 10, 2025 15:57
@eerhardt eerhardt merged commit 94be90a into dotnet:main Jun 10, 2025
497 of 499 checks passed
@eerhardt eerhardt deleted the FixAcaDataProtection branch June 10, 2025 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ACA] Allow setting of Development stack for containers
2 participants