Skip to content

Quarantine flaky test WithHttpCommand_UsesNamedHttpClient #9802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 10, 2025

This PR quarantines the flaky test Aspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_UsesNamedHttpClient by adding the [QuarantinedTest] attribute.

Changes Made

  • Added [QuarantinedTest("https://github.com/dotnet/aspire/issues/9800")] attribute to the WithHttpCommand_UsesNamedHttpClient test method
  • The test will now run in the outerloop workflow (tests-outerloop.yml) instead of the regular tests workflow (tests.yml)

Background

The QuarantinedTest attribute is used to mark tests that are flaky and don't fail deterministically. These tests are excluded from regular CI runs to prevent false failures, but are still executed in the outerloop workflow to monitor their behavior.

The attribute follows the established pattern used by other quarantined tests in the same file and references the GitHub issue tracking the underlying flakiness.

Fixes #9801.

…test

Co-authored-by: radical <1472+radical@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Quarantine test 'Aspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_UsesNamedHttpClient' via Copilot Quarantine flaky test WithHttpCommand_UsesNamedHttpClient Jun 10, 2025
@Copilot Copilot AI requested a review from radical June 10, 2025 19:52
Copilot finished work on behalf of radical June 10, 2025 19:52
@radical radical marked this pull request as ready for review June 10, 2025 19:53
@Copilot Copilot AI review requested due to automatic review settings June 10, 2025 19:53
@radical radical requested a review from mitchdenny as a code owner June 10, 2025 19:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR marks the WithHttpCommand_UsesNamedHttpClient test as quarantined to prevent intermittent failures in the main CI and moves its execution to the outerloop workflow.

  • Added [QuarantinedTest] attribute to the flaky test
  • Ensured the test will run only in the tests-outerloop.yml pipeline
Comments suppressed due to low confidence (1)

tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs:236

  • The quarantined test attribute references issue #9800, but this PR description and closing metadata refer to issue #9801. Please confirm the correct issue URL is used.
[QuarantinedTest("https://github.com/dotnet/aspire/issues/9800")]

@radical radical enabled auto-merge (squash) June 10, 2025 19:55
@JamesNK
Copy link
Member

JamesNK commented Jun 10, 2025

@DamianEdwards It seems like all the WithHttpCommand tests are flaky. Could you take a look at them?

@radical radical merged commit 9c6d1f6 into main Jun 11, 2025
260 of 266 checks passed
@radical radical deleted the copilot/fix-9801 branch June 11, 2025 03:47
@davidfowl
Copy link
Member

he knows its on his list

@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Error loading sessions

Retrying...

Successfully merging this pull request may close these issues.

Quarantine test 'Aspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_UsesNamedHttpClient' via Copilot
4 participants