Quarantine flaky ResourceCommandServiceTests #9836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
radical
June 11, 2025 16:58
davidfowl
approved these changes
Jun 11, 2025
|
Update the issue url for |
…rReplica to #9832 Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copilot finished work on behalf of
radical
June 11, 2025 17:48
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR quarantines two flaky tests in
ResourceCommandServiceTeststhat have been causing intermittent failures:ExecuteCommandAsync_HasReplicas_Success_CalledPerReplica(Issue Failing test: Aspire.Hosting.Tests.ResourceCommandServiceTests.ExecuteCommandAsync_HasReplicas_Success_CalledPerReplica #9833)ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplica(Issue Failing test: Aspire.Hosting.Tests.ResourceCommandServiceTests.ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplica #9834)The tests are marked with the
QuarantinedTestattribute to move them from the regular test workflow to the outerloop workflow, preventing build failures while the underlying flakiness is investigated and resolved.Changes made:
using Aspire.TestUtilities;import[QuarantinedTest("https://github.com/dotnet/aspire/issues/9833")]to the success test[QuarantinedTest("https://github.com/dotnet/aspire/issues/9834")]to the failure testThis follows the established pattern for quarantining flaky tests in the Aspire codebase, ensuring these tests continue to run in the outerloop workflow while not blocking regular CI builds.
Fixes #9835.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.