-
Notifications
You must be signed in to change notification settings - Fork 674
Use single ActivitySource across CLI components #9848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Try again @copilot |
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Done! I've consolidated all 11 individual ActivitySource instances across the CLI components into a single shared Fixed in commit 019a27b. |
…DI pattern - Rename class and file from AspireCliActivitySource to AspireCliActivityTelemetry - Change from static singleton to non-static class - Register in DI container and inject into all consuming services - Update all usage sites to use injected telemetry service instead of static access - Update test files to provide telemetry parameter in manual instantiations Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
…mporary file Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
…AspireCliTelemetry.cs Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
The activity itself should have the command name |
Updated all CLI command activities to include the command name for better tracing context. Each command (run, add, new, publish, deploy) now passes its name when starting activities. Fixed in commit coming next. |
Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.
Original issue description:
Fixes #9843.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.