Skip to content

Skip calling certain Tasks if the input is empty #22689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
Original file line number Diff line number Diff line change
@@ -787,7 +787,7 @@
<!-- Figure out which frameworks are really dynamic libraries, and only publish those -->
<FilterStaticFrameworks
SessionId="$(BuildSessionId)"
Condition="'$(IsMacEnabled)' == 'true'"
Condition="'$(IsMacEnabled)' == 'true' And '@(_FrameworkToPublish->Count())' != '0'"
FrameworkToPublish="@(_FrameworkToPublish)"
>
<Output TaskParameter="FrameworkToPublish" ItemName="_FilteredFrameworkToPublish" />
@@ -804,7 +804,7 @@

-->
<GetFullPaths
Condition="'$(IsMacEnabled)' == 'true'"
Condition="'$(IsMacEnabled)' == 'true' And '@(_FilteredFrameworkToPublish->Count())' != '0'"
SessionId="$(BuildSessionId)"
Items="@(_FilteredFrameworkToPublish)"
Metadata="Identity;SourceDirectory"
@@ -2415,6 +2415,7 @@ global using nfloat = global::System.Runtime.InteropServices.NFloat%3B

-->
<GetFileSystemEntries
Condition="'@(_BindingPackagesFromReferencedAssembliesDirectoriesExists->Count())' != '0'"
SessionId="$(BuildSessionIdIfConnected)"
DirectoryPath="@(_BindingPackagesFromReferencedAssembliesDirectoriesExists)"
Pattern="*"
2 changes: 1 addition & 1 deletion msbuild/Xamarin.Shared/Xamarin.Shared.targets
Original file line number Diff line number Diff line change
@@ -1500,7 +1500,7 @@ Copyright (C) 2018 Microsoft. All rights reserved.

<CoreMLCompiler
SessionId="$(BuildSessionId)"
Condition="'$(IsMacEnabled)' == 'true'"
Condition="'$(IsMacEnabled)' == 'true' And '@(CoreMLModel->Count())' != '0'"
ToolExe="$(CoreMLCompilerExe)"
ToolPath="$(CoreMLCompilerPath)"
Models="@(CoreMLModel)"