Skip to content

Ignore .slnx #48729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Ignore .slnx #48729

merged 2 commits into from
May 14, 2025

Conversation

edvilme
Copy link
Contributor

@edvilme edvilme commented Apr 25, 2025

Fixes #48728

Description

As mentioned in the issue, when opening a .sln file in a directory that contains a .slnx file, the .slnx file is displayed as content in the project. It should be ignored the same way .sln files are.

Risk

Low - This shouldn't alter behavior.

Regression

No - This started occurring following new support for slnx

Testing

Manual testing was done.

@edvilme edvilme requested a review from a team April 25, 2025 23:19
@Forgind
Copy link
Contributor

Forgind commented Apr 27, 2025

Can you check whether, if someone has a slnx but no sln, it shows up at the top of that same pane?

Also, if you want this in 3xx, you'll need a tactics template

@edvilme
Copy link
Contributor Author

edvilme commented Apr 29, 2025

Can you check whether, if someone has a slnx but no sln, it shows up at the top of that same pane?

Also, if you want this in 3xx, you'll need a tactics template

Do you mean when opening a .slnx file and no .sln? If that is the case, no, it does not show up at the top of that pane.

Update: I mean, it does show the slnx file as a solution file, but does not show it as a "solution item"

image

@nagilson
Copy link
Member

I'm not sure why branch lockdown wasn't automatically removed, but... we should merge this, right?

@edvilme edvilme enabled auto-merge (squash) May 13, 2025 19:59
@edvilme edvilme merged commit 36e942d into dotnet:release/9.0.3xx May 14, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants